Skip to content

fix: pin the correct version of sjson in v2#1334

Merged
ysmolski merged 2 commits intomasterfrom
yury/correctly_pin_modules
Nov 17, 2025
Merged

fix: pin the correct version of sjson in v2#1334
ysmolski merged 2 commits intomasterfrom
yury/correctly_pin_modules

Conversation

@ysmolski
Copy link
Copy Markdown
Contributor

@ysmolski ysmolski commented Oct 24, 2025 •
edited by coderabbitai Bot
Loading

"Replace" for gqlgen was removed as redundant. It was pinned in individual modules before.
Pin the sjson module to the version actually used in v2.

Summary by CodeRabbit

  • Chores
    • Updated internal dependency versions for maintenance purposes.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 24, 2025 •
edited
Loading

Walkthrough

The pull request downgrades the tidwall/sjson dependency in v2/go.mod from v1.2.5 to v1.0.4. This is a single-line version change with no functional code modifications or new logic introduced.

Changes

Cohort / File(s) Change Summary
Dependency Version Update
v2/go.mod		 Downgrade tidwall/sjson dependency from v1.2.5 to v1.0.4

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "fix: pin the correct version of sjson in v2" directly aligns with the main change in the changeset. The raw summary confirms that the only modification is downgrading the tidwall/sjson dependency from v1.2.5 to v1.0.4 in v2/go.mod, which is precisely what the title describes—pinning sjson to the correct version in v2. The title is concise, specific, and clearly conveys the primary change without vague terminology or unnecessary details. A teammate reviewing the commit history would immediately understand the purpose of this PR.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch yury/correctly_pin_modules
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b9cd6f and 31f1ed1.

⛔ Files ignored due to path filters (2)
  • go.work is excluded by !**/*.work
  • v2/go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • v2/go.mod (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build and test (go 1.25 / windows-latest)
  • GitHub Check: Build and test (go 1.25 / ubuntu-latest)
  • GitHub Check: Build and test (go 1.25 / ubuntu-latest)
🔇 Additional comments (2)
v2/go.mod (2)

1-80: Clarify the gqlgen Replace removal mentioned in the PR description.

The PR description states: "The PR removes a redundant Replace for gqlgen that had been pinned in individual modules previously." However, the provided file still shows tool github.com/99designs/gqlgen at line 80. Clarify whether:

  1. The gqlgen Replace removal is part of a different file (e.g., top-level go.mod)?
  2. The PR description is misleading or outdated?
  3. This is a separate, incomplete change?

29-29: Confirm the sjson version is actually v1.0.4 as claimed, not a downgrades from v1.2.5.

Based on verification: v1 is considered stable, and the codebase actively uses DeleteBytes, SetRawBytes, and SetBytes APIs which are core stable functions. The go.sum confirms v1.0.4 is currently specified. The PR's stated rationale—"pinning sjson to the version actually used in v2"—appears valid, as the change aligns the declared version with actual dependencies. No API incompatibilities are evident between v1.0.4 and later v1.x versions.

Comment @coderabbitai help to get the list of available commands and usage tips.

StarpTech
StarpTech approved these changes Nov 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ysmolski ysmolski merged commit 0009898 into master Nov 17, 2025
10 checks passed
@ysmolski ysmolski deleted the yury/correctly_pin_modules branch November 17, 2025 09:05
@StarpTech StarpTech mentioned this pull request Nov 17, 2025
Merged
StarpTech added a commit that referenced this pull request Nov 21, 2025
@StarpTech
chore(master): release 2.0.0-rc.239 (#1345)
d95839a 
🤖 I have created a release *beep* *boop*
---


##
[2.0.0-rc.239](v2.0.0-rc.238...v2.0.0-rc.239)
(2025-11-21)


### Features

* allows hook in the subscriptions
([#1309](#1309))
([79d7e79](79d7e79))


### Bug Fixes

* pin the correct version of sjson in v2
([#1334](#1334))
([0009898](0009898))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added subscription hooks functionality to provide more flexible
subscription management options and enhanced control over subscription
workflows.

* **Bug Fixes**
* Fixed and pinned the correct dependency version to prevent potential
compatibility issues and ensure stable operation across environments.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StarpTech StarpTech StarpTech approved these changes

@devsergiy devsergiy Awaiting requested review from devsergiy devsergiy is a code owner

@Noroth Noroth Awaiting requested review from Noroth Noroth is a code owner

@jensneuse jensneuse Awaiting requested review from jensneuse jensneuse is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ysmolski @StarpTech